Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WS-2008] Bundle with tsup to support CJS + ESM #41

Merged
merged 3 commits into from
Dec 15, 2023
Merged

[WS-2008] Bundle with tsup to support CJS + ESM #41

merged 3 commits into from
Dec 15, 2023

Conversation

jackyzha0
Copy link
Member

@replit/river is currently published as raw ESM files. This means that the end-consumer needs to transpile it if they are using CJS. Let's transpile for both.

@jackyzha0 jackyzha0 requested a review from moudy December 15, 2023 20:05
Copy link

linear bot commented Dec 15, 2023

WS-2008 Package meta cleanup @replit/river

Our dependency setup confuses repl-it-web

  • probably make ws and sinclair/typebox peerdependencies
  • look into how we export so we dont need to do code transpilation from within nextjs

Copy link

@moudy moudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@jackyzha0 jackyzha0 merged commit 192f4f2 into main Dec 15, 2023
4 checks passed
@jackyzha0 jackyzha0 deleted the tsup branch December 15, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants