Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip support #180

Merged
merged 27 commits into from
Dec 19, 2023
Merged

pip support #180

merged 27 commits into from
Dec 19, 2023

Conversation

blast-hardcheese
Copy link
Collaborator

@blast-hardcheese blast-hardcheese commented Dec 13, 2023 •
edited
Loading

Depends on #183, Minified diff

Draft, pending making constraints work, as well as tests

What's been manually tested:

  • upm install
  • upm add <pkg> [pkg...]
  • upm list

seems to work well as a first pass.

For notes about the pip lockfile, please refer to this discussion

masad-frost
masad-frost reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@masad-frost masad-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice progress

internal/backends/python/python.go Outdated Show resolved Hide resolved
internal/backends/python/python.go Outdated Show resolved Hide resolved
internal/backends/python/python.go Outdated Show resolved Hide resolved
internal/backends/python/python.go Show resolved Hide resolved
internal/backends/python/requirements.go Show resolved Hide resolved
@blast-hardcheese blast-hardcheese force-pushed the dstewart/pip-support branch 2 times, most recently from 3cf885e to d4c1129 Compare December 15, 2023 17:51
@blast-hardcheese blast-hardcheese force-pushed the dstewart/pip-support branch 8 times, most recently from 6432520 to 26ec4e8 Compare December 18, 2023 18:29
@blast-hardcheese blast-hardcheese marked this pull request as ready for review December 18, 2023 18:49
@blast-hardcheese blast-hardcheese requested a review from a team as a code owner December 18, 2023 18:49
@blast-hardcheese blast-hardcheese requested review from cdmistman and removed request for a team December 18, 2023 18:49
@blast-hardcheese blast-hardcheese added the enhancement New feature or request label Dec 18, 2023
@blast-hardcheese blast-hardcheese force-pushed the dstewart/pip-support branch 2 times, most recently from 9ccc8ba to a38e2c6 Compare December 18, 2023 21:38
cdmistman
cdmistman reviewed Dec 18, 2023
View reviewed changes
Makefile Show resolved Hide resolved
cdmistman
cdmistman reviewed Dec 18, 2023
View reviewed changes
internal/cli/cmds.go Outdated Show resolved Hide resolved
cdmistman
cdmistman reviewed Dec 18, 2023
View reviewed changes
test-suite/utils/upm.go Outdated Show resolved Hide resolved
cdmistman
cdmistman reviewed Dec 18, 2023
View reviewed changes
test-suite/utils/upm.go Outdated Show resolved Hide resolved
cdmistman
cdmistman approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@cdmistman cdmistman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides last 2 nits lgtm!

@blast-hardcheese blast-hardcheese merged commit 59aaaa1 into main Dec 19, 2023
4 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/pip-support branch December 19, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masad-frost masad-frost masad-frost left review comments

@airportyh airportyh airportyh left review comments

@cdmistman cdmistman cdmistman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blast-hardcheese @airportyh @masad-frost @cdmistman