-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix poetry show package dir #182
Conversation
A question from @airportyh around how to test this seems to have been eaten by GitHub, but the following is an example:
Since we are delegating the |
The logic we had before didn't work and didn't support all of the functionaity available in Poetry. Better to not be able to look up the path if the path is wrong than to not be able to give reliably correct results.
9a02a42
to
1ffaff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! thanks!
How poetry calculates the env path has changed, so instead of trying to guess, just delegate to
poetry env
. If the environment hasn't been created we don't get a path, which is only relevant if we're in a completely blank environment, so it's hopefully not that bad.PythonPoetryBackend
poetry env list
to find the active environment