Ranked packages for python guess #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
airportyh and
cdmistman
and removed request for
a team and
airportyh
blast-hardcheese
force-pushed
the
dstewart/ranked-packages-for-python-guess
branch
3 times, most recently
from
72ca8b7 to
e54f51f
Compare
cdmistman
reviewed
Jan 2, 2024
cdmistman
reviewed
Jan 2, 2024
cdmistman
approved these changes
Jan 2, 2024
- moduleToPypiPackageOverride is now exclusively for guessing and search overrides. - moduleToPypiPackageAliases is used only for guessing. Installing by way of search will then subsequently dereference the package in moduleToPypiPackageOverride, but without burdening the user's search experience.
blast-hardcheese
force-pushed
the
dstewart/ranked-packages-for-python-guess
branch
from
b33f5dd to
1132e8c
Compare
blast-hardcheese
force-pushed
the
dstewart/ranked-packages-for-python-guess
branch
from
ff8a787 to
37a81c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work towards #15
Guessover to an import statement mapping to multiple packages that can provide that importguessFollow-on work to this as follows:
internal/nix/python_map.jsonto also include information about which package roots (the shallowest module in a package with more than one child, to start. There may be some utility in indexing what classes are available as well, but that'll come in the future)$PYTHONPATHto exclude packages fromguessthat already supply necessary imports.