Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/Evict uv if we see requirements.txt #299

Merged

Conversation

blast-hardcheese
Copy link
Collaborator

Why

If a repl has pyproject.toml as well as requirements.txt we accidentally choose uv over requirements.txt.

What changed

uv chooses to evict itself if requirements.txt exists.

Test plan

Create a pyproject.toml alongside requirements.txt in a repl. upm which-language should return pip

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner October 15, 2024 21:24
@blast-hardcheese blast-hardcheese requested review from vlinkz and removed request for a team October 15, 2024 21:24
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) October 15, 2024 21:25
@blast-hardcheese blast-hardcheese merged commit 1059d21 into main Oct 15, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/uv-accidentally-selects-over-pip branch October 15, 2024 21:36
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants