New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and internalise value state #23

Open

bxvd wants to merge 4 commits into repodio:master from bxvd:master

bxvd commented Aug 4, 2021 •

edited

Loading

Fix typo on prop type checking
Add a setValue function and a value field in the state, so that a parent component won't have to maintain its own state and re-render itself on every value change.

bxvd added 4 commits

August 4, 2021 14:31


          Fix typo on checking type of props.onSlidingStart

38a5bd0


          Merge pull request #1 from bxvd/hotfix/typecheck-typo

62bb257

Fix typo on checking type of props.onSlidingStart


          Update type declaration

fdff181


          Allow for using state for value

bxvd changed the title ~~Fix typo in prop type checking~~ Fix typo and internalise value state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet