Skip to content

Commit

Permalink
Remove Unique ID set
Browse files Browse the repository at this point in the history
  • Loading branch information
HardNorth committed Feb 19, 2024
1 parent a521802 commit e2754ff
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
- JUnit 5 dependency marked as `compileOnly` to avoid overriding JUnit 5 API version for users, by @HardNorth
- JSR 305 dependency marked as `implementation` to force users specify their own versions, by @HardNorth
- Client version updated on [5.2.5](https://github.com/reportportal/client-java/releases/tag/5.2.5), by @HardNorth
### Removed
- Setting of Unique ID on Test Step and Configuration start, as redundant action, by @HardNorth

## [5.2.1]
### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,6 @@ protected StartTestItemRQ buildStartStepRq(@Nonnull final ExtensionContext conte
rq.setStartTime(startTime);
rq.setName(createStepName(context));
rq.setDescription(description);
rq.setUniqueId(context.getUniqueId());
rq.setType(itemType == TEMPLATE ? SUITE.name() : itemType.name());
String codeRef = getCodeRef(context);
rq.setCodeRef(codeRef);
Expand Down Expand Up @@ -705,6 +704,7 @@ protected StartTestItemRQ buildStartStepRq(@Nonnull final ExtensionContext conte
* @return Request to ReportPortal
*/
@Nonnull
@SuppressWarnings("unused")
protected StartTestItemRQ buildStartConfigurationRq(@Nonnull Method method, @Nonnull ExtensionContext parentContext,
@Nonnull ExtensionContext context, @Nonnull ItemType itemType) {
StartTestItemRQ rq = new StartTestItemRQ();
Expand All @@ -717,8 +717,6 @@ protected StartTestItemRQ buildStartConfigurationRq(@Nonnull Method method, @Non
rq.setName(createConfigurationName(method.getDeclaringClass(), method));
rq.setDescription(createConfigurationDescription(method.getDeclaringClass(), method));
}
String uniqueId = parentContext.getUniqueId() + "/[method:" + method.getName() + "()]";
rq.setUniqueId(uniqueId);
ofNullable(context.getTags()).ifPresent(it -> rq.setAttributes(it.stream()
.map(tag -> new ItemAttributesRQ(null, tag))
.collect(Collectors.toSet())));
Expand Down

0 comments on commit e2754ff

Please sign in to comment.