Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate: add spanish language #556

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

translate: add spanish language #556

wants to merge 1 commit into from

Conversation

lauren-d
Copy link
Contributor

  • Adds spanish language in translate service.

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@lauren-d lauren-d self-assigned this Jun 26, 2023
@lauren-d
translate: add spanish language
47ab482 
* Adds spanish language in translate service.

Co-Authored-by: Lauren-D <[email protected]>
This was referenced Jun 26, 2023
Open
Open
jma
jma requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to modify also the translate-loader.ts file. Please find fr.json in the entire project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma requested changes

@PascalRepond PascalRepond PascalRepond approved these changes

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@lauren-d lauren-d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lauren-d @Garfield-fr @jma @zannkukai @PascalRepond