chore: fix the navigation #614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-navigation-fix
branch
2 times, most recently
from
15442de
to
92895f8
Compare
PascalRepond
requested changes
May 7, 2024
There was a problem hiding this comment.
This is not what was asked in rero/rero-ils#3628.
The problem that the back button/browser function sometimes takes us to an editor view, sometimes not is not fixed by this PR.
jma
approved these changes
May 8, 2024
When a resource is added or modified, it is not always returned to the correct page. The editor now uses the previous url to redirect. * Closes rero/rero-ils#3628. Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
zub-navigation-fix
branch
from
92895f8
to
4ed680e
Compare
PascalRepond
approved these changes
May 14, 2024
|
After discussion, we decided to wait on this PR because it has unintended effects on the current workflows for professionnals, for example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource is added or modified, it is not always returned to the correct page. The editor now uses the previous url to redirect.