Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: fix can remove field when a hide expression exists #635

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 25, 2024

  • Avoids the possiblity to remove or add a field with an hide expression (tash button on the label component).
  • Adds an exemple in the demo editor.
  • Does not add a field with an hide expression during the edit initialization. In the previous versions the field was in the editor and in the completion menu.

Co-Authored-by: Johnny Mariéthoz [email protected]

* Avoids the possiblity to remove or add a field with an hide expression (tash button on the label component).
* Adds an exemple in the demo editor.
* Does not add a field with an hide expression during the edit initialization. In the previous versions the field was in the editor and in the completion menu.
* Fixes hide then show a field of array type at the root level. An example has been added.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-remove-hide-expression branch from 2e53c6c to 8982791 Compare July 25, 2024 13:20
@PascalRepond PascalRepond marked this pull request as ready for review July 26, 2024 07:38
@jma jma requested review from Garfield-fr and PascalRepond July 29, 2024 13:21
@jma jma merged commit 065d918 into rero:staging Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants