-
Notifications
You must be signed in to change notification settings - Fork 372
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
arrow2-convert
migration 2: non-serde blueprint types (#3855)
This PR introduces `ObjectKind::Blueprint` into our codegen framework. `Blueprint` objects are as expressive as `Datatype` objects (i.e. they don't have the artificial limitations that we impose on `Component` objects), but still implement the `Component` trait. Blueprint objects live in a separate module so as not to pollute LSP/docs/etc. This allows us to replace existing `arrow2_convert`-based blueprint types with fbs definitions instead. This PR does not cover `SerdeField` shenanigans, that comes next.
- Loading branch information
Showing
42 changed files
with
835 additions
and
257 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
include "./blueprint/auto_space_views.fbs"; | ||
include "./blueprint/panel_view.fbs"; |
22 changes: 22 additions & 0 deletions
22
crates/re_types/definitions/rerun/blueprint/auto_space_views.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
include "arrow/attributes.fbs"; | ||
include "python/attributes.fbs"; | ||
include "rust/attributes.fbs"; | ||
|
||
include "rerun/datatypes.fbs"; | ||
include "rerun/attributes.fbs"; | ||
|
||
namespace rerun.blueprint; | ||
|
||
// --- | ||
|
||
/// A flag indicating space views should be automatically populated. | ||
/// | ||
/// Unstable. Used for the ongoing blueprint experimentations. | ||
struct AutoSpaceViews ( | ||
"attr.arrow.transparent", | ||
"attr.rust.derive": "Copy, Default", | ||
"attr.rust.repr": "transparent", | ||
"attr.rust.tuple_struct" | ||
) { | ||
enabled: bool (order: 100); | ||
} |
19 changes: 19 additions & 0 deletions
19
crates/re_types/definitions/rerun/blueprint/panel_view.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
include "arrow/attributes.fbs"; | ||
include "python/attributes.fbs"; | ||
include "rust/attributes.fbs"; | ||
|
||
include "rerun/datatypes.fbs"; | ||
include "rerun/attributes.fbs"; | ||
|
||
namespace rerun.blueprint; | ||
|
||
// --- | ||
|
||
/// The state of the panels. | ||
/// | ||
/// Unstable. Used for the ongoing blueprint experimentations. | ||
struct PanelView ( | ||
"attr.rust.derive": "Copy" | ||
) { | ||
is_expanded: bool (order: 100); | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.