Skip to content

Commit

Permalink
Auto-approve workflow run fixes (#3911)
Browse files Browse the repository at this point in the history
### What

- Document `@rerun-bot approve` in `CONTRIBUTING.md`
- Skip the approval workflow entirely for PRs in the `rerun-io` org

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3911) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3911)
- [Docs
preview](https://rerun.io/preview/50d3bc6c32945c627d077e0894362ca9ea199c97/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/50d3bc6c32945c627d077e0894362ca9ea199c97/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
  • Loading branch information
jprochazk authored Oct 18, 2023
1 parent 582f2fd commit cca5cd9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/auto_approve.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ jobs:
approve-workflow-runs:
name: "Check for approval"
runs-on: ubuntu-latest
if: ${{ github.event_name == 'pull_request_target' || github.event.issue.pull_request }}
if: |
github.event.pull_request.head.repo.owner.login != 'rerun-io' &&
(github.event_name == 'pull_request_target' || github.event.issue.pull_request)
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ All PR:s are merged with [`Squash and Merge`](https://docs.github.com/en/pull-re

Our CI will run benchmarks on each merged PR. The results can be found at <https://rerun-io.github.io/rerun/dev/bench/>.

Pull requests from external contributors require approval for CI runs. This can be done manually, by clicking the `Approve and run` button:

![Image showing the approve and run button](https://github.com/rerun-io/rerun/assets/1665677/ead5c04f-df02-4f20-9093-37cfce097b44)

Members of the `rerun-io` organization and collaborators in the `rerun-io/rerun` repository may enable auto-approval of workflow runs for a single PR by commenting with `@rerun-bot approve`:

![PR comment with the text `@rerun-bot approve`](https://github.com/rerun-io/rerun/assets/1665677/b5f07f3f-ea95-44a4-8eb7-f07c905f96c3)

### Adding dependencies
Be thoughtful when adding dependencies. Each new dependency is a liability which lead to increased compile times, a bigger binary, more code that can break, a larger attack surface, etc. Sometimes it is better to write a hundred lines of code than to add a new dependency.

Expand Down

1 comment on commit cca5cd9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: cca5cd9 Previous: 582f2fd Ratio
mono_points_arrow/generate_message_bundles 27614778 ns/iter (± 4473516) 18798695 ns/iter (± 917230) 1.47

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.