Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen: Multi-pass refactoring & support for --check #3918

Merged
merged 12 commits into from
Oct 19, 2023
Merged

Codegen: Multi-pass refactoring & support for --check #3918

merged 12 commits into from
Oct 19, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 18, 2023 •
edited by github-actions bot
Loading

  • Adds a new CodeFormatter trait.
  • Adds a new trait-based generic generate_code helper, and reimplement all language-specific backends in terms of it.
  • Adds --check flag.
  • Use --check instead of git dirtyness checks on CI.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 🚜 refactor Change the code, not the functionality codegen/idl labels Oct 18, 2023
@teh-cmc teh-cmc changed the base branch from main to cmc/arrow2convert_be_gone_5 October 18, 2023 15:31
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 18, 2023

Failing as it should: https://github.com/rerun-io/rerun/actions/runs/6563187568/job/17826835626?pr=3918

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 18, 2023

And then succeeding as it should: https://github.com/rerun-io/rerun/actions/runs/6563258948/job/17827053364?pr=3918

@teh-cmc teh-cmc marked this pull request as ready for review October 18, 2023 16:09
@jleibs jleibs self-requested a review October 18, 2023 18:24
@teh-cmc teh-cmc force-pushed the cmc/arrow2convert_be_gone_5 branch from 3d6bae9 to d139fa5 Compare October 19, 2023 08:04
Base automatically changed from cmc/arrow2convert_be_gone_5 to main October 19, 2023 08:06
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Oct 19, 2023
@teh-cmc teh-cmc merged commit 22e0188 into main Oct 19, 2023
25 of 26 checks passed
@teh-cmc teh-cmc deleted the cmc/codegen_check branch October 19, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
codegen/idl 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a --check argument to cargo codegen
2 participants
@teh-cmc @jleibs