Use arrow-rs in ArrowBuffer
#8201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🦀 Rust API
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
changed the title
ArrowNativeType trait bound to ArrowBufferarrow-rs in ArrowBuffer
Wumpf
approved these changes
Nov 25, 2024
| fn from(value: arrow2::buffer::Buffer<T>) -> Self { | ||
| Self(value) | ||
| fn from(arrow2_buffer: arrow2::buffer::Buffer<T>) -> Self { | ||
| let num_elements = arrow2_buffer.len(); |
There was a problem hiding this comment.
didn't the fat comment up there say that this is a num_bytes in arrow2? That would make this wrong then if I understand correctly
Your unit test seems to pass this though, confusing.
There was a problem hiding this comment.
This is why I wrote a unit test - arrow2 is confusing and maybe wrongly documented:
The comment is gone too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_arrow2toarrow#3741ArrowBufferwrapper to exposearrow-rsbuffers rather thanarrow2#2978