Port codegen of arrow datatype to arrow1 #8206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
force-pushed
the
emilk/arrow1-codegen
branch
from
7170b3d
to
f9ba68b
Compare
emilk
added
🦀 Rust API
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12007096160 |
abey79
approved these changes
Nov 25, 2024
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12007483726 |
emilk
added a commit
that referenced
this pull request
Nov 25, 2024
* Follows #8206 * Part of #3741 ## Changes To implement nullable unions, we have a `_null_marker: Null` variants in all our unions. This means all our unions are nullable. Previously we would only mark a struct field as nullable if it was declared as such in the `.fbs` file, but `arrow-rs` complains about this. So with this PR, if a struct field refers to a union type, that struct field will be marked as `nullable: true` in the datatype (in Rust, Python and C++).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_arrow2toarrow#3741