Port more of the viewer to arrow1 #8539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🏹 arrow
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12411355672 |
emilk
force-pushed
the
emilk/arrow-port-viewer
branch
from
d17a6aa to
a6ba10b
Compare
|
DRAFT: I broke the dataframe view |
emilk
force-pushed
the
emilk/arrow-port-viewer
branch
from
a6ba10b to
badc2bc
Compare
emilk
commented
Jan 6, 2025
| @@ -649,6 +649,7 @@ impl PyRecordingView { | |||
| /// This schema will only contain the columns that are included in the view via | |||
| /// the view contents. | |||
| fn schema(&self, py: Python<'_>) -> PyResult<PySchema> { | |||
| #![allow(clippy::unnecessary_wraps)] // In case of feature != "remote" | |||
There was a problem hiding this comment.
Unrelated thing I discovered when running cargo clippy (without --all-features)
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12631012679 |
teh-cmc
changed the title
teh-cmc
changed the title
teh-cmc
requested changes
Jan 6, 2025
emilk
force-pushed
the
emilk/arrow-port-viewer
branch
from
bc4f4ab to
c955f1d
Compare
teh-cmc
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
re_arrow2toarrow#3741Port most of our viewer-facing code to arrow1