Skip to content

Commit

Permalink
Notes for doing this better in the future
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-r-bigelow committed Sep 16, 2023
1 parent f0ca6b9 commit 7b5804d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ node_modules/
.vscode/
*git/
.env
src/json/people.json
src/static/json/people.json
6 changes: 5 additions & 1 deletion src/_includes/partials/randomAvatars.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
<script type="application/javascript">
const teamName = '{{ teamName }}';
const container = document.querySelector(`[data-team="${teamName}"]`);
// TODO: should probably put people.json into src/_data and pre-load the data instead of using fetch
// TODO: should probably put people.json into src/_data and pre-load the
// data instead of using fetch

// ... AND should be fetching people.json as part of the local build, not
// just github; see also: https://www.11ty.dev/docs/quicktips/eliminate-js/
fetch('/static/json/people.json')
.then((response) => response.json())
.then(({ data }) => {
Expand Down

0 comments on commit 7b5804d

Please sign in to comment.