Add basic operators to the syntax widget #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryyppy
reviewed
Jan 4, 2021
| @@ -87,6 +114,78 @@ let allItems = [ | |||
| category: Other, | |||
| component: controlflow_ifelse, | |||
| }, | |||
| { | |||
| id: "integer-addition", | |||
There was a problem hiding this comment.
this data is good for drafting and testing, but since we will include a ton of syntax constructs, I am pretty sure that this will not scale on a bundle level, so we need to factor everything out into some server side rendered solution of some sort.
So what I think would be best is to put the metadata in the frontmatter of each syntax construct file, e.g. operators_integer_addition.mdx:
---
id: "integer-addition"
keywords: ["plus", "add", "addition", "sum", "int", "integer"]
name: "+"
summary: "This is the `integer addition` operator."
category: "operators"
---
You can of course still hook your components up with the SyntaxLookupWidget to test your keywords, but we will remove that code pretty soon later on, just so you know.
There was a problem hiding this comment.
Thanks @ryyppy that makes sense, updated.
|
Looking good. Will merge this for now and update the overview issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for #162
Add some of the basic operators.
Happy to hear any corrections or suggestions for improvements.