Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax lookup: let \"" #242

Merged

Conversation

kevanstannard
Copy link
Contributor

Suggestion for #162

@kevanstannard kevanstannard changed the title Syntax Lookup: let \"" Syntax lookup: let \"" Mar 7, 2021
@bobzhang
Copy link
Member

bobzhang commented Mar 8, 2021

This feature should not be exposed to end users.

  • It may break lots of compiler invariants.
  • We don't provide any guarantee that the compiler will compile the name as is

@kevanstannard
Copy link
Contributor Author

kevanstannard commented Mar 8, 2021

Thanks @bobzhang

@ryyppy what do you think? Should we remove the content here?:

https://rescript-lang.org/docs/manual/latest/use-illegal-identifier-names

@ryyppy
Copy link
Member

ryyppy commented Mar 9, 2021

Yeah the PR makes it look like a feature that users can safely rely on without any consequences. It is supposed to be an escape hatch only feature though.

Will discuss this internally. I believe this feature should be documented (but phrased differently), otherwise it might be abused. The goal is to document all language constructs available in the language.

I will adapt your texts later on, just keep the PR open.

Regarding the manual entry: This page is important and should stay as it is. In later ReScript versions we might be able to reduce some use-cases for let \"", so it will get simpler.

@kevanstannard
Copy link
Contributor Author

Hi @ryyppy @bobzhang anything I can do to help resolve this one? I can have a go at adapting the text, or whatever else you have in mind. Happy to be guided by you.

@ryyppy ryyppy merged commit ae27c3f into rescript-lang:master Sep 7, 2021
bobzhang added a commit that referenced this pull request Sep 7, 2021
bobzhang added a commit that referenced this pull request Sep 7, 2021
…ookup-let-invalid

Revert "Syntax lookup: let \"" (#242)"
@kevanstannard kevanstannard deleted the syntax-lookup-let-invalid branch September 9, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants