-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build binaries for Linux ARM64 #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
for some reasons it still fails with the following error:
what is really weird is the fact that it builds using Any idea @rolandpeelen? |
@tsnobip - I’ll have a look tomorrow. Seems that the musl build should, just work (tm). But I’ll have a look. What exact OS are you on? And are you deploying inside a docker? What can I do to reproduce / have a look? |
@rolandpeelen yes the build is inside docker, it uses node:22.1.0-alpine3.19 docker image as base but I don't have a repro open-sourced. |
I think I found the issue |
it's all working now! |
@tsnobip -- Nice! Yeah, that might be the one. Awesome. I tried locally, seems to work for me too 🙌. Feel free to merge! |
Today rescript ships bsb for ARM64 but not rewatch, so this PR allows rewatch to support the same targets.