Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build binaries for Linux ARM64 #142

Merged
merged 3 commits into from
Nov 20, 2024
Merged

build binaries for Linux ARM64 #142

merged 3 commits into from
Nov 20, 2024

Conversation

tsnobip
Copy link
Contributor

@tsnobip tsnobip commented Nov 19, 2024

Today rescript ships bsb for ARM64 but not rewatch, so this PR allows rewatch to support the same targets.

Copy link
Member

@rolandpeelen rolandpeelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tsnobip tsnobip marked this pull request as draft November 19, 2024 19:33
@tsnobip tsnobip marked this pull request as ready for review November 19, 2024 19:36
@tsnobip tsnobip marked this pull request as draft November 19, 2024 19:46
@tsnobip
Copy link
Contributor Author

tsnobip commented Nov 19, 2024

for some reasons it still fails with the following error:

/app/node_modules/rescript/linux/bsc.exe: Invalid ELF image for this architecture

what is really weird is the fact that it builds using rescript build.

Any idea @rolandpeelen?

@rolandpeelen
Copy link
Member

@tsnobip - I’ll have a look tomorrow. Seems that the musl build should, just work (tm). But I’ll have a look.

What exact OS are you on? And are you deploying inside a docker? What can I do to reproduce / have a look?

@tsnobip
Copy link
Contributor Author

tsnobip commented Nov 19, 2024

@tsnobip - I’ll have a look tomorrow. Seems that the musl build should, just work (tm). But I’ll have a look.

What exact OS are you on? And are you deploying inside a docker? What can I do to reproduce / have a look?

@rolandpeelen yes the build is inside docker, it uses node:22.1.0-alpine3.19 docker image as base but I don't have a repro open-sourced.

@tsnobip
Copy link
Contributor Author

tsnobip commented Nov 20, 2024

I think I found the issue

@tsnobip
Copy link
Contributor Author

tsnobip commented Nov 20, 2024

it's all working now!

@tsnobip tsnobip marked this pull request as ready for review November 20, 2024 09:00
@rolandpeelen
Copy link
Member

@tsnobip -- Nice! Yeah, that might be the one. Awesome. I tried locally, seems to work for me too 🙌. Feel free to merge!

@tsnobip tsnobip requested a review from rolandpeelen November 20, 2024 09:01
@tsnobip tsnobip merged commit c7ff668 into master Nov 20, 2024
2 checks passed
@tsnobip tsnobip deleted the linux_arm64 branch November 20, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants