Back to pull request #1145

Update writing-collateral-plugins.md #3523

Sign in to view logs

Triggered via pull request May 20, 2024 13:47

pmckelvy1

opened #1145

fix-writing-collat-docs

Status Success

Total duration 40m 55s

Artifacts –

tests.yml

on: pull_request

Deployment Scripts

Plugin Tests (Mainnet)

Plugin Tests (Base)

Integration Tests

Monitor Tests (Mainnet)

Annotations

18 warnings

Lint Checks

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint Checks: contracts/facade/Facade.sol#L30

When fallback is not payable you will not be able to receive ether

Lint Checks: contracts/facade/Facade.sol#L30

Fallback function must be simple

Lint Checks: contracts/facade/Facade.sol#L35

Avoid to use inline assembly. It is acceptable only in rare cases

Lint Checks: test/Facade.test.ts#L14

'ActFacet' is defined but never used

Lint Checks: test/plugins/individual-collateral/compoundv2/CTokenFiatCollateral.test.ts#L923

'currRate' is assigned a value but never used

Lint Checks: test/plugins/individual-collateral/compoundv3/CometTestSuite.test.ts#L27

'MAX_UINT48' is defined but never used

Lint Checks: test/plugins/individual-collateral/compoundv3/CometTestSuite.test.ts#L32

'advanceTime' is defined but never used

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Monitor Tests (Mainnet)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Deployment Scripts

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Plugin Tests (Base)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Integration Tests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Scenario Tests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Extreme Tests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Plugin Tests (Mainnet)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.