-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRUST M-13: Use latest Convex contract #1008
Conversation
TRUST M-13: Use latest Convex contract
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to ask convex about the new earmarkRewards()
function to make sure we don't need to call it after deployment or something.
We also have more mentions of the CvxMining lib to remove over in scripts/deployment
. Do a search for cvxMiningLib
.
contracts/plugins/assets/curve/cvx/vendor/ConvexStakingWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/curve/cvx/vendor/ConvexStakingWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/curve/cvx/vendor/ConvexStakingWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/curve/cvx/vendor/ConvexStakingWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/curve/cvx/vendor/ConvexStakingWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/curve/cvx/vendor/ConvexStakingWrapper.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ConvexStakingWrapper
contract based on their last versionCvxMiningLib
in our scripts and tests. Kept it as part of the deployment file for backwards compatibility.