Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUST M-13: Use latest Convex contract #1008

Merged
merged 11 commits into from
Nov 27, 2023
Merged

TRUST M-13: Use latest Convex contract #1008

merged 11 commits into from
Nov 27, 2023

Conversation

julianmrodri
Copy link
Contributor

@julianmrodri julianmrodri commented Nov 3, 2023

  • Bump code for ConvexStakingWrapper contract based on their last version
  • Removes the need of the CvxMiningLib in our scripts and tests. Kept it as part of the deployment file for backwards compatibility.
  • Removes ownership and related management functions.

@julianmrodri julianmrodri changed the title TRUST M-13: Use latest Convez contract TRUST M-13: Use latest Convex contract Nov 3, 2023
@julianmrodri julianmrodri marked this pull request as draft November 3, 2023 13:30
Copy link

openzeppelin-code bot commented Nov 3, 2023

TRUST M-13: Use latest Convex contract

Generated at commit: 5f3ef44b3f553f319bf8b2f0169f535992f707de

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector high
note
low
critical
Total
1
36
18
2
57
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@julianmrodri julianmrodri marked this pull request as ready for review November 3, 2023 14:59
Copy link
Collaborator

@tbrent tbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ask convex about the new earmarkRewards() function to make sure we don't need to call it after deployment or something.

We also have more mentions of the CvxMining lib to remove over in scripts/deployment. Do a search for cvxMiningLib.

Copy link
Collaborator

@pmckelvy1 pmckelvy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pmckelvy1 pmckelvy1 merged commit f1459e6 into 3.1.0 Nov 27, 2023
9 checks passed
@pmckelvy1 pmckelvy1 deleted the convex-vendor branch November 27, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants