Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment + verification scripts for sFRAX #1010

Merged
merged 5 commits into from
Nov 8, 2023
Merged

deployment + verification scripts for sFRAX #1010

merged 5 commits into from
Nov 8, 2023

Conversation

tbrent
Copy link
Collaborator

@tbrent tbrent commented Nov 7, 2023

Needs 2 reviewers to sign off on

@tbrent
Copy link
Collaborator Author

tbrent commented Nov 8, 2023

(small thing)

I see no reason to code the FORK_BLOCK in the CI config; it should be the case that when someone runs a local devchain that they are able to run our deploy scripts. So whatever block number it uses, it should also work locally. Seems like fork-block-number.default is the most natural thing to use.

julianmrodri
julianmrodri previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@julianmrodri julianmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM checked oracle timeout and error for Mainnet

Base automatically changed from sfrax-plugin to master November 8, 2023 16:32
@tbrent tbrent dismissed julianmrodri’s stale review November 8, 2023 16:32

The base branch was changed.

@julianmrodri julianmrodri self-requested a review November 8, 2023 16:34
julianmrodri
julianmrodri approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@julianmrodri julianmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbrent tbrent merged commit 714de4d into master Nov 8, 2023
9 checks passed
@tbrent tbrent deleted the sfrax-scripts branch November 8, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianmrodri julianmrodri julianmrodri approved these changes

@akshatmittal akshatmittal akshatmittal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbrent @akshatmittal @julianmrodri