Feature/dutch auction cb bid #1027
Conversation
There was a problem hiding this comment.
Everywhere in the DutchTradeRouter let's use our unit notation to document the type of each variable: https://github.com/reserve-protocol/protocol/blob/master/docs/solidity-style.md#units-in-comments
There was a problem hiding this comment.
Nice tests! Unit notation looks good.
Left a comment about a variable I'm not sure is needed in the callback function.
Let's also touch docs/mev.md and at least point them towards the existence of this router, though I think that document should remain describing how to bid against a DutchTrade directly.
…reflect new way of using it
jankjr
force-pushed
the
feature/dutch-auction-cb-bid
branch
from
927a7ee to
5cf82e1
Compare
…o reflect new design
jankjr
force-pushed
the
feature/dutch-auction-cb-bid
branch
from
5cf82e1 to
782658d
Compare
|
1/9/24:
|
There was a problem hiding this comment.
The bidType state tracking is uglier than I'd like it to be, but I don't see a good alternative. I tried a few things and none of them are better.
I did leave some fussy comments, though. I think it's important for this contract to be as clear as possible, and there were a few things around the edges I thought detracted from that.
Also, I think we should swap the implementation order of bid() and bidWithCallback(), I think it makes more sense for bid() to come first.
No description provided.