rollback unwrapping changes. #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I must be missing something: the numbers show it's more costly to transfer wrapped tokens than unwrapped, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't think we necessarily want to do this. just made this pr so we could discuss based on the harder gas numbers in the target branch
fix-ftoken.unwrapped ctoken/ftoken transfer:
110849wrapped ctoken/ftoken transfer:
175997+59% increase
issue, RToken, single collateral basket unwrapped ctoken/ftoken:
677455issue, RToken, single collateral basket wrapped ctoken/ftoken:
753143+11% increase
(11% will go down as more tokens that are not ctoken/ftoken are added to the basket. ie. eUSD difference will be closer to 6%)