Trst m 14 #982
Merged
Trst m 14 #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmckelvy1
requested changes
Oct 20, 2023
| @@ -3248,7 +3249,6 @@ describe(`Recollateralization - P${IMPLEMENTATION}`, () => { | |||
| collateral1.address, | |||
| collateral0.address, | |||
| issueAmount, | |||
| config.minTradeVolume, | |||
There was a problem hiding this comment.
kind of worried about this change since the function is not edited in this pr, meaning there might have been something wrong with this test?
There was a problem hiding this comment.
lol looks like config.minTradeVolume was set to fp('1e-2') and config.maxTradeSlippage set to fp('0.01'), so we're all good here.
There was a problem hiding this comment.
I also confirmed by hand this test was running properly
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the test changes come from the fact that tests need to both be able to instantiate a new asset (use pre-buffer oracleTimeout) and also need to be able to fast-forward to the end of the oracleTimeout to cause an oracle to become stale. It would be nice to just always read this value off of an asset, but often we're fast forwarding outside of the context of any single asset.