Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRUST QA-5/10/11: Optimizations on BasketHandler #986

Merged
merged 3 commits into from
Oct 24, 2023
Merged

TRUST QA-5/10/11: Optimizations on BasketHandler #986

merged 3 commits into from
Oct 24, 2023

Conversation

julianmrodri
Copy link
Contributor

  • Replaces continue with break to optimize gas
  • Uses lastStatus to optimize gas
  • Tracks status when basket is disabled (keeps state consistent)

tbrent
tbrent reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@tbrent tbrent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I left a comment here but realized it's wrong...

Anyway, LGTM after we remove the change to P0 I commented on below

contracts/p0/BasketHandler.sol Outdated Show resolved Hide resolved
@julianmrodri julianmrodri merged commit 8d96002 into 3.1.0 Oct 24, 2023
9 checks passed
@julianmrodri julianmrodri deleted the feat-quotecustom branch October 24, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrent tbrent tbrent left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianmrodri @tbrent