Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRUST M-8: Reward distribution in RewardableERC20 #993

Closed
wants to merge 522 commits into from
Closed

TRUST M-8: Reward distribution in RewardableERC20 #993

wants to merge 522 commits into from

Conversation

julianmrodri
Copy link
Contributor

  • Fixes incorrect reward distribution in RewardableERC20 by adding a decimals buffer = 9.
  • Adds regression testing with the example from Trust with the exact values to confirm its distributing correctly
  • Adapts tests, now shares and balance are in different units. So we need to multiply or divide by the "Shares Factor" (bn(10).pow(DECIMALS_BUFFER)) to get the previous comparisons to work. This is the only change accross the file.

tbrent and others added 30 commits May 12, 2023 11:20
@tbrent
even simpler
7309e1d
@tbrent
nit
bfa151a
@tbrent
fix StRSR extreme tests
efa2a74
@tbrent
only run extreme tests when EXTREME=1
7a8703b
@tbrent
fix failing tests
db72f7b
@tbrent
Merge pull request #816 from reserve-protocol/3.0.0-gas-optimize
c96ee4b 
3.0.0 gas optimizations
@akshatmittal
Merge pull request #822 from reserve-protocol/master
eab5a39 
remove sol 4.24 from 3.0.0
@tbrent
gas snapshots
0192cda
@tbrent
Merge pull request #823 from reserve-protocol/3.0.0-gas-snapshots
6498795 
gas snapshots
@julianmrodri
new auction length validations
585222b
@julianmrodri
adjust broker tests
f74264c
@julianmrodri
fix comment
68df6a8
@julianmrodri
fix revenue tests
b647511
@tbrent
Merge pull request #827 from reserve-protocol/feat-broker
48fb3b8 
Broker validations
@tbrent
make first offered dutch auction price exactly highPrice; + comments
0b85b08
@tbrent
further simplification
339fcea
@tbrent
remove kruft --dev depedency
e043d10
@tbrent
DutchTrade: 30% / 70% auction split with 4/5 as the exp base
849f1e3
@tbrent
Revenues tests
65824a8
@tbrent
Recollateralization tests
3e91bf1
@tbrent
remove prime nonce and update tests (#824)
5f94e2d
@tbrent
final answer: 33%/66% split with 18.6 minute auctions
af4bff7
@tbrent
new gas snapshots
a39beea
@pmckelvy1
Correct vendor files (#826)
e590d4a 
* move plugin files to vendor folders if needed.

* fix compilation.
@tbrent
backwards compatible FacadeRead/Act (#825)
924f518 
* backwards-compatible facades

* goerli phase1 deployments

* add Multicall to FacadeAct and test

* goerli FacadeAct with multicall

* revert if neither 3.0.0 or <=2.1.0 interfaces work

* fix forwardRevenue step

* update goerli FacadeAct
@tbrent
fix failing tests
dacb348
@tbrent
Merge branch '3.0.0' into manipulated-prices
a732632
@tbrent
docs/system-design.md
403615b
@tbrent
fix Broker test
9f2cf7e
@tbrent
system-design.md: withdrawalLeak
14ea9cf
tbrent and others added 29 commits October 2, 2023 19:59
@tbrent
more cleanup
4106b1a
@tbrent
more cleanup
7262b6c
@tbrent
fix broken tests
7de7885
@tbrent
gas snapshots
14a46ae
@tbrent
remove some bad merge kruft
1adc381
@tbrent
comments and cosmetics
9a67530
@tbrent
Merge branch 'master' into 3.1.0
a9043a8
@julianmrodri
Trust M-01 & M-02: RevenueTrader.settleTrade() (#966)
6a8a2bf
@julianmrodri
Trust M-11: Fix storage slots (#968)
ae598c6
@julianmrodri
Revert "Trust M-01 & M-02: RevenueTrader.settleTrade() (#966)"
ce38d3b 
This reverts commit 6a8a2bf.
@julianmrodri @tbrent
Trust M-01 & M-02: RevenueTrader.settleTrade() (#969)
ef0a1c3 
Co-authored-by: Taylor Brent <[email protected]>
@julianmrodri
TRUST M-06: Keep buffer when minting rtoken revenue (#972)
535dbc3
@julianmrodri
TRUST Recommendation 1: reward and underlying checks in RewardERC20 w…
ab79276 
…rappers (#976)
@julianmrodri
fix lint in Revenue traders
2de6b0d
@julianmrodri
TRUST QA-2: DefaultThreshold check for Non-Self referential (#980)
29c0f4c
@tbrent
Trust M-07: RTokenAsset.refresh() (#964)
a007c47
@julianmrodri @tbrent
TRUST L-7: Restriction on reportViolation (#981)
de352e1 
Co-authored-by: Taylor Brent <[email protected]>
@tbrent
Trst-M-11 (#979)
fcade85
@julianmrodri @tbrent
TRUST M-4: Call reward accounting functions (#984)
35b063c 
Co-authored-by: Taylor Brent <[email protected]>
@tbrent
Merge branch 'master' into 3.1.0
b23cf5c
@tbrent
gas snapshots
124e401
@julianmrodri @tbrent
TRUST QA-4: Smoother exposedRefPrice in case of default (#987)
6fccc54 
Co-authored-by: Taylor Brent <[email protected]>
@tbrent
Trst m 14 (#982)
c1e9f04
@julianmrodri
TRUST QA-3: Set correct version (#985)
6bc0b02
@julianmrodri
TRUST QA-5/10/11: Optimizations on BasketHandler (#986)
8d96002
@julianmrodri @tbrent
TRUST QA-6/7: Optimizations in Distributor (#988)
c20ea91 
Co-authored-by: Taylor Brent <[email protected]>
@tbrent
gas snapshots
5aa2d4e
@julianmrodri
TRUST QA-21: minimum voting delay (#990)
a7f76a7
@julianmrodri
add buffer for decimals in shares calculations
ca53604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julianmrodri @tbrent @akshatmittal @pmckelvy1 @jankjr