Skip to content

Commit

Permalink
fix: update minimum and maximum net rate field in item (#2870)
Browse files Browse the repository at this point in the history
* fix: update minimum and maximum net rate field in item

* fix: update the alert message

---------

Co-authored-by: Sanket322 <shahsanket322003.com>
(cherry picked from commit 128cc73)
  • Loading branch information
Sanket322 authored and mergify[bot] committed Dec 16, 2024
1 parent 1aee6ec commit 1340540
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ frappe.ui.form.on('GST HSN Code', {
method: 'india_compliance.gst_india.doctype.gst_hsn_code.gst_hsn_code.update_taxes_in_item_master',
callback: function(r) {
if(r.message){
frappe.show_alert(__('Item taxes updated'));
frappe.show_alert(__('Items with this HSN code will be updated shortly'));
}
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ def update_item_document(taxes, hsn_code):
"item_tax_template": tax.item_tax_template,
"tax_category": tax.tax_category,
"valid_from": tax.valid_from,
"minimum_net_rate": tax.minimum_net_rate,
"maximum_net_rate": tax.maximum_net_rate,
},
)

Expand Down
2 changes: 2 additions & 0 deletions india_compliance/gst_india/overrides/item.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,7 @@ def set_taxes_from_hsn_code(doc):
"item_tax_template": tax.item_tax_template,
"tax_category": tax.tax_category,
"valid_from": tax.valid_from,
"minimum_net_rate": tax.minimum_net_rate,
"maximum_net_rate": tax.maximum_net_rate,
},
)

0 comments on commit 1340540

Please sign in to comment.