Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] email tracking opt-in #1658

Merged
merged 4 commits into from
Oct 6, 2024
Merged

[feature] email tracking opt-in #1658

merged 4 commits into from
Oct 6, 2024

Conversation

donrestarone
Copy link
Contributor

  • basic implementation for email tracking opt-in

tracking pixel

Screen Shot 2024-10-06 at 12 16 19 PM

UI

Screen Shot 2024-10-06 at 12 16 42 PM

@donrestarone
Copy link
Contributor Author

donrestarone commented Oct 6, 2024

https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658

need to fix review apps:

remote: -----> Cleaning up...        
[100](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:101)
remote: -----> Building review-1658 from herokuish        
[101](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:102)
remote: -----> Adding BUILD_ENV to build environment...        
[102](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:103)
remote:        BUILD_ENV added successfully        
[103](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:104)
remote:        -----> Warning: Multiple default buildpacks reported the ability to handle this app. The first buildpack in the list below will be used.        
[104](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:105)
remote:               Detected buildpacks: multi ruby nodejs        
[105](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:106)
remote:        -----> Multipack app detected        
[106](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:107)
remote: =====> Downloading Buildpack: https://github.com/heroku/heroku-buildpack-nodejs.git        
[107](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:108)
remote: =====> Detected Framework: Node.js        
[108](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:109)
remote:                
[109](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:110)
remote: -----> Build failed        
[110](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:111)
remote:        !     Multiple package managers declared in package.json        
[111](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:112)
remote:                
[112](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:113)
remote:        Installing dependencies using the wrong package manager can result in missing packages or subtle bugs        
[113](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:114)
remote:        in production. Only one of the following fields should be used, all others should be removed:        
[114](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:115)
remote:                
[115](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:116)
remote:        - npm version detected in engines.npm (6.14.x)        
[116](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:117)
remote:        - yarn version declared in engines.yarn (1.22.x)        
[117](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:118)
remote:                
[118](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:119)
remote:        https://devcenter.heroku.com/articles/nodejs-support        
[119](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:120)
remote:                
[120](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:121)
remote:  !     Failure during app build        
[121](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:122)
remote:  !     Removing invalid image tag dokku/review-1658:latest        
[122](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:123)
remote:  !     App build failed        
[123](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:124)
To ssh://***:22/review-1658
[124](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:125)
 ! [remote rejected]   fe0e7b4f267b38e42fd0e603e87d483181ac40da -> master (pre-receive hook declined)
[125](https://github.com/restarone/violet_rails/actions/runs/11203379753/job/31140673189?pr=1658#step:5:126)
error: failed to push some refs to 'ssh://***:22/review-1658'

Copy link

github-actions bot commented Oct 6, 2024

Deployed review-app can be viewed at https://review-1658.violet-test.net

Copy link

github-actions bot commented Oct 6, 2024

Deployed review-app can be viewed at https://review-1658.violet-test.net

@donrestarone donrestarone changed the base branch from master to rc October 6, 2024 18:43
@donrestarone donrestarone merged commit c6d66bf into rc Oct 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant