Allow to change the default provider to replicated #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
enable-migration-from-local-loglet
branch
from
dc02d36 to
e21b592
Compare
AhmedSoliman
approved these changes
Feb 13, 2025
| @@ -617,8 +616,8 @@ async fn sync_cluster_controller_metadata() -> anyhow::Result<()> { | |||
| enum ClusterConfigurationUpdateError { | |||
| #[error("Unchanged")] | |||
| Unchanged, | |||
| #[error("Changing default provider kind is not supported")] | |||
| ChangingDefaultProviderNotSupported, | |||
| #[error("Changing default provider kind to {0} is not supported. Choose the replicated loglet instead")] | |||
There was a problem hiding this comment.
Suggested change
| #[error("Changing default provider kind to {0} is not supported. Choose the replicated loglet instead")] | |
| #[error("Changing default provider kind to {0} is not supported. Choose the 'replicated' instead")] |
This commit allows users to change the default log provider to replicated even if the cluster has been fully provisioned. This allows users to migrate from a single node deployment with a local loglet to a replicated loglet and then a multi node deployment. Additionally, this commit enables the LogsController to react to default provider changes. If the new default provider is the replicated loglet, then the logs controller will reconfigure all logs.
tillrohrmann
force-pushed
the
enable-migration-from-local-loglet
branch
from
e21b592 to
a47881e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to change the default log provider to replicated even if the
cluster has been fully provisioned. This allows users to migrate from a single node
deployment with a local loglet to a replicated loglet and then a multi node deployment.
Additionally, this commit enables the LogsController to react to default provider changes.
If the new default provider is the replicated loglet, then the logs controller will reconfigure
all logs.