Fix thumbnails on videos #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves significant changes to the
lib/utils/compressor.dartfile to replace theffmpeg_clipackage with thefc_native_video_thumbnailpackage for generating video thumbnail. The reason behind is that ffmpeg has to be provided by the system, and not by the application, meaning that if the system does not have ffmpeg, then it cannot generate thumbnails.fc_native_video_thumbnaildoes use native implementations, but it does not support LinuxSadly there's no other cross platform option when it comes to extracting a thumbnail other than ffmpeg, and screenshotting a video player is not possible (SachinGanesh/screenshot#62)
Package changes:
ffmpeg_clidependency and addedfc_native_video_thumbnail