Remove the module and dynamic cli concepts #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more logical and allows adding collectors to retis/src/collect in later patches. Signed-off-by: Antoine Tenart <[email protected]>
This is only moving patches, not changing anything besides the import mod paths. Following patches will further remove the module concept. Signed-off-by: Antoine Tenart <[email protected]>
Signed-off-by: Antoine Tenart <[email protected]>
Instead directly use collectors. In details this removes the ModuleId, Module trait, Modules abstraction and a lot of the dynamic steps that used to happen when using modules. Following-up patches are needed to complete to make things completely clean but those are not strictly about removing the module concept. Signed-off-by: Antoine Tenart <[email protected]>
This also unties the SectionId <> collector cli arguments relationship. Signed-off-by: Antoine Tenart <[email protected]>
There is no remaining user after collectors stopped from using it. Signed-off-by: Antoine Tenart <[email protected]>
Using a more logical order, grouping related parameters and trying to display then in a logical order (of importance). Signed-off-by: Antoine Tenart <[email protected]>
Signed-off-by: Antoine Tenart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A high level view is we now have a more manual (but way simpler) way of handling cli arguments and we only have a collectors concept instead of the collectors+modules one. A lot of cleanup was allowed by such changes.