collector: ct: fix truncation of zone id #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zone id is 16-bit, but for some reason is casted to u8 on read. This makes retis report incorrect values. Fixes: e883af8 ("module: add conntrack module") Signed-off-by: Ilya Maximets <[email protected]>
|
Thanks, @igsilya for spotting this, for the fix, and for the test. |
|
It seems [0] https://cirrus-ci.com/task/5509164367085568 Edit: Nevermind. You already did in #482, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zone id is 16-bit, but for some reason is casted to u8 on read. This makes retis report incorrect values.
Fixes: e883af8 ("module: add conntrack module")