Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mapping for Amazon purchases. #101

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

jaraco
Copy link
Collaborator

@jaraco jaraco commented Jun 4, 2023

No description provided.

@jaraco
Copy link
Collaborator Author

jaraco commented Jun 4, 2023

I've added tests, but due to #102 and #103 and #104, I'm giving up on trying to run the tests. Please refine the tests to your tastes, and let me know if there's more I can do to refine the implementation.

@jaraco
Copy link
Collaborator Author

jaraco commented Jun 5, 2023

After submitting this PR, I'm now beginning to wonder if I should use a different model for inclusion/exclusion of payment methods. Originally, I had a simpler use-case, but now I'm discovering that exclusion is too lenient and picks up unwanted transactions. I'm now reconsidering whether "inclusion" should be customizable too.

@reubano
Copy link
Owner

reubano commented Jan 31, 2024

After submitting this PR, I'm now beginning to wonder if I should use a different model for inclusion/exclusion of payment methods. Originally, I had a simpler use-case, but now I'm discovering that exclusion is too lenient and picks up unwanted transactions. I'm now reconsidering whether "inclusion" should be customizable too.

Ok, let me know what you decide. Unless you are saying the lib is missing a needed feature.

@jaraco
Copy link
Collaborator Author

jaraco commented Feb 18, 2024

After submitting this PR, I'm now beginning to wonder if I should use a different model for inclusion/exclusion of payment methods. Originally, I had a simpler use-case, but now I'm discovering that exclusion is too lenient and picks up unwanted transactions. I'm now reconsidering whether "inclusion" should be customizable too.

Ok, let me know what you decide. Unless you are saying the lib is missing a needed feature.

Sorry. I could have followed up. In 4cd5884, I added both inclusion and exclusion support, so it's ready to be reviewed in its current state.

@jaraco jaraco merged commit 634aea9 into reubano:master Feb 19, 2024
@jaraco jaraco deleted the feature/amazon-mapping branch February 19, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants