Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update go-c8y lib to fix notifications2 connect/reconnect errors #407

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

reubenmiller
Copy link
Owner

@reubenmiller reubenmiller commented Oct 2, 2024

Fixes to the c8y notification2 commands regarding the websocket connection to Cumulocity IoT and the parsing of the messages.

Changes include:

  • Fix message parsing bug which was caused by failing to allocate memory during parsing which resulted in corrupted message parsing (fields were mixed). This would result in corrupted ack messages which the server would then disconnect the client, and a reconnection loop would start.
  • Update websocket library to prevent use of closed network connection errors
  • Explicitly close websocket before reconnecting

@reubenmiller reubenmiller merged commit 200b418 into v2 Oct 2, 2024
4 checks passed
@reubenmiller reubenmiller deleted the fix-notifications2-connect-errors branch October 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant