Add command to test a local bluprint from disk #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarib
force-pushed
the
test-command
branch
2 times, most recently
from
f361903 to
1fc8a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented
bluprint test ../local-diras suggested in #21.I tried to reuse as much as possible from
bluprint start, which means importing some functions from../startin thetestcommand. I build a tarball of the given directory, in order to reuse most of those functions. It could probably be refactored to something cleaner, but I didn't attempt that here.I made a best effort attempt at parsing
.gitignoreand ignoring those files when building the tarball. Another approach usinggit archiveis available here: https://github.com/jarib/bluprint/tree/test-command-using-git-archive. The downside is that the files then have to be commited in the local bluprint's repo to be picked up by thetestcommand. Seems like it would be easy to forget and a quite frustrating DX, so I prefer the approach in this PR.