Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentatively fix the version of tfsec at v1.28.1 #96

Closed
wants to merge 1 commit into from
Closed

Tentatively fix the version of tfsec at v1.28.1 #96

wants to merge 1 commit into from

Conversation

yu-iskw
Copy link

@yu-iskw yu-iskw commented Sep 8, 2023

The GitHub Actions doesn't work with the latest version tfsec v1.28.2. So, it would be good to tentatively fix the tfsec version with v1.28.1 right now, as it may take a bit time to identify the root cause of breaking changes on the tfsec side.

The GitHub Actions doesn't work with the latest version tfsec v1.28.2. So, it would be good to tentatively fix the tfsec version with `v1.28.1` right now, as it may take a bit time to identify the root cause of breaking changes on the tfsec side.
@yu-iskw yu-iskw marked this pull request as ready for review September 8, 2023 02:25
@yu-iskw yu-iskw changed the title Tentatively fix the version of tfset at v1.28.1 Tentatively fix the version of tfsec at v1.28.1 Sep 8, 2023
@thaim
Copy link

thaim commented Sep 8, 2023

This is because tfsec v1.28.2 adds a transition message. tfsec print a message even if the json format is specified.
It seems that there is no option to suppress this message.

$ tfsec1282 . --format json 

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
{
	"results": []
}

aquasecurity/tfsec#2067

@yu-iskw
Copy link
Author

yu-iskw commented Sep 8, 2023

@thaim Nice catch. I have sent a pull request to tfsec so that tfsec print out the transition message as standard error. By doing so, we are able to parse the result of JSON format of tfsec with JSON parsers like jq.

aquasecurity/tfsec#2099

@shogo82148
Copy link
Contributor

closed by #98

@shogo82148 shogo82148 closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants