Fix storages deprecation warnings #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a great solution, but a workaround.
This isn't really used, but I think having caching is a win
browniebroke
force-pushed
the
fix/storages-deprecations
branch
from
637fa4e
to
4abfa8e
Compare
browniebroke
commented
Jul 11, 2023
| from django.conf import settings | ||
| from django.core.files.base import ContentFile | ||
| from django.core.files.storage import get_storage_class | ||
|
|
||
| if django.VERSION >= (4, 2): |
There was a problem hiding this comment.
Used the versioned block approach over the try/catch ImportError as this is automatically fixable by django-upgrade when we'll need to remove it.
|
Hey @frankwiles and @jefftriplett, Can you please check this and the other compatibility improvement PR (#363)? Thank you! |
|
@KOliver94 I'll ping Frank and see if he has time tomorrow to check it. He's a little closer to the project than me, and he can cut release. |
jefftriplett
force-pushed
the
upgrade-django-to-4-2
branch
from
3d59bd0
to
8969b61
Compare
frankwiles
approved these changes
Oct 19, 2023
frankwiles
added a commit
that referenced
this pull request
Oct 19, 2023
* ⚙️ Adds Django 4.2 support and fixes trove classifiers * :shirts: Runs black on code to make CI happy * :shirts: Runs isort on code to make CI happy * 💚 Updates test to match exception copy * 📝 mirrors old README.rst to make docs work Not a great solution, but a workaround. * ⚙️ Adds pip cache support * 🔥 Removes 4.0 from grid because it's no longer supported * ⚙️ Updates cache-key This isn't really used, but I think having caching is a win * ⚙️ Adds missing file * 🔥 Removes cache line * Fix storages deprecation warnings (#372) * ⚙️ Adds Django 4.2 support and fixes trove classifiers * :shirts: Runs black on code to make CI happy * :shirts: Runs isort on code to make CI happy * 💚 Updates test to match exception copy * 📝 mirrors old README.rst to make docs work Not a great solution, but a workaround. * ⚙️ Adds pip cache support * 🔥 Removes 4.0 from grid because it's no longer supported * ⚙️ Updates cache-key This isn't really used, but I think having caching is a win * ⚙️ Adds missing file * 🔥 Removes cache line * Fix storages deprecation warnings --------- Co-authored-by: Jeff Triplett <[email protected]> * Fix isort ordering --------- Co-authored-by: Bruno Alla <[email protected]> Co-authored-by: Frank Wiles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #363 to resolve the deprecation warning coming out of the new unified
STORAGESsetting.Fix #366
Closes #365