Fix cache consistency bug while deleting resources #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pablorsk, what do you think of this one? I'm struggling to test locally as I can't manage to find a way to build the lib and link it to my project. Cheers, |
|
@pablorsk any news ? |
|
@pablorsk please merge this and release update!!! |
|
@cesar-tonnoir did you find a solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Cachememory.removeResourceis executed whenever a resource gets deleted.This method aims to remove the deleted resource from the collections persisted in service cache.
Bug:
Resources that aren't directly related to the deleted resource get removed from the cache as well.
After investigation, we've found out this is caused by the
removeResourcemethod that loops over all the available collections, and removes one item every time, whether or not the target resource has been found.This seems to be caused by the use of the
splicemethod chained withfindIndex:findIndexreturns -1 when the resource isn't found, andspliceremoves the last item of the array.Resolution:
If
findIndexreturns -1, avoid callingsplice