Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing osx arm64 wheel #58

Closed
wants to merge 2 commits into from
Closed

Conversation

wckdouglas
Copy link

@wckdouglas wckdouglas commented May 28, 2023

Hi, this PR intends to fix 2 things:

Let me know if it makes sense!

Tested with commit 8bc1576, artifact.zip from here

$ sysctl -n machdep.cpu.brand_string
Apple M1
$ unzip artifact.zip
$ pip --version
pip 23.1.2 from /Users/../lib/python3.10/site-packages/pip (python 3.10)
$ pip install tmap_viz-1.0.18-cp310-cp310-macosx_11_0_arm64.whl --force-reinstall
$ python --version
Python 3.10.11
$ python -c "import tmap"

dependabot bot and others added 2 commits May 28, 2023 11:56
Bumps [numpy](https://github.com/numpy/numpy) from 1.19.3 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.19.3...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Adding arm64 osx env variable

cbiw build variable to build only one wheel for eac hgha

cbiw build variable to build only one wheel for each gha

cbiw build variable to build only one wheel for each gha

cbiw build variable to build only one wheel for each gha

environment variable in githubenv

environment variable in githubenv

environment variable in githubenv
@doublethefish
Copy link
Collaborator

#68 supersedes this commit. Thanks for the commit, but I will close and abandon this.

One reason is because the actual intended fix appears to have been merged with the dependabot change and you (or I) would have to unpick it.

@wckdouglas
Copy link
Author

@doublethefish that sounds great! thanks for pushing the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants