updated plot with sharex=True and wrap with a mode 'constant' #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alexlib, and sorry for my too late answer 🙏. |
rfezzani
reviewed
Jan 2, 2023
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| y, x = np.meshgrid(np.arange(nl), np.arange(nc), indexing='ij') | |||
|
|
|||
| wI1 = warp(I1, np.array([y+v, x+u]), mode='nearest') | |||
| wI1 = warp(I1, np.array([y+v, x+u]), mode='constant') | |||
There was a problem hiding this comment.
Suggested change
| wI1 = warp(I1, np.array([y+v, x+u]), mode='constant') | |
| wI1 = warp(I1, np.array([y+v, x+u]), mode='edge') |
Thank you for spotting this 😉. Instead of the constant mode, I would recommend the edge mode: the constant mode will in most cases introduce high gradient values on the image border, and thus create artifacts 😕
| @@ -74,7 +74,7 @@ def _tvl1(I0, I1, u0, v0, dt, lambda_, tau, nwarp, niter, tol, prefilter): | |||
| u = ndi.filters.median_filter(u, 3) | |||
| v = ndi.filters.median_filter(v, 3) | |||
|
|
|||
| wI1 = warp(I1, np.array([y+v, x+u]), mode='nearest') | |||
| wI1 = warp(I1, np.array([y+v, x+u]), mode='constant') | |||
There was a problem hiding this comment.
Suggested change
| wI1 = warp(I1, np.array([y+v, x+u]), mode='constant') | |
| wI1 = warp(I1, np.array([y+v, x+u]), mode='edge') |
| @@ -238,7 +238,7 @@ def _ilk(I0, I1, u0, v0, rad, nwarp, gaussian, prefilter): | |||
| u = ndi.filters.median_filter(u, 3) | |||
| v = ndi.filters.median_filter(v, 3) | |||
|
|
|||
| wI1 = warp(I1, np.array([y+v, x+u]), mode='nearest') | |||
| wI1 = warp(I1, np.array([y+v, x+u]), mode='constant') | |||
There was a problem hiding this comment.
Suggested change
| wI1 = warp(I1, np.array([y+v, x+u]), mode='constant') | |
| wI1 = warp(I1, np.array([y+v, x+u]), mode='edge') |
| @@ -70,7 +70,7 @@ def parse_requirements_file(filename): | |||
| ], | |||
| install_requires=REQUIRES, | |||
| extras_require=EXTRA_REQUIRES, | |||
| python_requires='>=3.5', | |||
| python_requires='>=3.7', | |||
There was a problem hiding this comment.
I wonder if this change is mandatory 😕
| @@ -59,7 +59,7 @@ | |||
| # --- Show the result | |||
|
|
|||
| fig = plt.figure(figsize=(15, 4)) | |||
| ax0, ax1, ax2 = fig.subplots(1, 3, True) | |||
| ax0, ax1, ax2 = fig.subplots(1, 3) | |||
There was a problem hiding this comment.
Suggested change
| ax0, ax1, ax2 = fig.subplots(1, 3) | |
| ax0, ax1, ax2 = fig.subplots(1, 3, sharex=True, sharey=True) |
Probably not necessary, but it doesn't hurt ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new matplotlib requires explicit
sharex=Trueandsharey=Truescikit-image wrap changed to
constant(nearestdoes not exist anymore)