Update esterel-rhombus-lib and add examples, tests, and documentation for Rhombus Esterel #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellifteria
commented
Aug 8, 2024
ellifteria
commented
- Update Rhombus dependencies
- Fix bugs in Rhombus Esterel bindings
- Added Rhombus Esterel bindings for almost all of Racket functions
- Created Rhombus Esterel examples: tab bar, traffic light
- Add some Rhombus Esterel tests
- Document all Rhombus Esterel functions, macros, operators, etc.
- Add examples in most of the Rhombus Esterel documentation
implementation to Rhombus Converted Rhombus Lists to PairLists (Racket lists) in react, par, and ||| Add def_strl to Rhombus Add shorthand def_strl : for def : esterel: Add signal_index Add signal values! (i think. they work at a very basic level) signal definition now works fixed with_signal one signal bug Update signals
it's not a tab-bar in any sense, but that's a different problem :)
Add abort macro to Rhombus esterel/full and modify racket esterel/private/full to provide abort-when/proc, weak-abort/proc, and weak-abort-immediate/proc since those are required for abort in Rhombus esterel/full Add suspend macro to Rhombus and add is_trap function to Rhombus for Racket's trap? function Expose all imports into rhombus-lib from racket esterel/kernel and esterel/full
Rename reducer into_par to ||| in rhombus
Add rhombus test of pre. Add pre to esterel Remove `def_strl` macro Rename variables and export all kernel functions
Fix documentation dependencies Add example Update .gitignore Update doc/info.rkt
rfindler
reviewed
Aug 11, 2024
| @@ -1,3 +1,6 @@ | |||
| *~ | |||
| compiled/ | |||
| .DS_Store | |||
| **/.DS_Store | |||
| **/doc/ | |||
There was a problem hiding this comment.
probably doc should not be ignored (it shouldn't be checked in).
rfindler
reviewed
Aug 11, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| (define collection 'multi) | |||
|
|
|||
| (define deps '("base" "rhombus-prototype" "esterel-lib")) | |||
| (define deps '("base" "rhombus" "esterel-lib")) | |||
There was a problem hiding this comment.
I think it is probably better to avoid depending on the meta-pkg and instead depend on the specific packages that are directly needed. IIUC, this dependency is actually equivalent to writing just "rhombus-lib" here, but it pulls in all of the other rhombus pkgs too.
rfindler
reviewed
Aug 11, 2024
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| (define deps '("base" | |||
| "esterel-lib" "esterel-doc" | |||
| "esterel-rhombus-lib" "rhombus" | |||
There was a problem hiding this comment.
ditto for this "rhombus" dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.