Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all processes, not just the victim #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eriksw
Copy link

@eriksw eriksw commented Jan 26, 2021

When selecting a process to kill, print a line for every process instead of
just the selected victim. This follows the behavior of the kernel OOM killer,
which logs a similar whole-system snapshot of memory usage when invoked.

When selecting a process to kill, print a line for every process instead of
just the selected victim. This follows the behavior of the kernel OOM killer,
which logs a similar whole-system snapshot of memory usage when invoked.
@eriksw
Copy link
Author

eriksw commented Jan 26, 2021

This verbose logging is critical when trying to diagnose situations where the application you care about on a system is killed while it was using a small percentage of the system's total memory.

Aside: It's been over 10 years since I did anything in C. I'm willing to try to make any refinements necessary to get this to a mergeable state, but anything complicated might be beyond me.

@rfjakob
Copy link
Owner

rfjakob commented Apr 18, 2021

Thanks, I can understand that this can be helpful. But I think this should be enabled through a --verbose flag instead of per default.

Copy link
Owner

@rfjakob rfjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be enabled via verbose flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants