Update top-of-tree GPU Operator OLM bundle image path #59
Conversation
WalkthroughThe changes update the default value for the GPU operator bundle image across the project. The new value now points to GitHub Container Registry instead of the GitLab registry. This update is applied in documentation, configuration code, and tests to ensure consistency when deploying from a bundle. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
/cc @empovit @TomerNewman |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
76-76: Correctly updated the GPU Operator bundle image pathThe default value for
NVIDIAGPU_BUNDLE_IMAGEhas been updated to use GitHub Container Registry instead of GitLab registry, which aligns with the PR objective.For consistency with other list items in the document, consider using an asterisk (*) instead of a dash (-) for this bullet point.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
76-76: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
README.md(1 hunks)internal/deploy/deploy.go(1 hunks)internal/deploy/deploy_test.go(1 hunks)tests/nvidiagpu/deploy-gpu-test.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- tests/nvidiagpu/deploy-gpu-test.go
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
76-76: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
🔇 Additional comments (2)
internal/deploy/deploy_test.go (1)
33-33: Updated test expectation to match the new default bundle image pathThe test has been properly updated to expect the new GitHub Container Registry path, ensuring consistency with the implementation.
internal/deploy/deploy.go (1)
20-20: Updated default bundle image path in BundleConfig structThe default value for the GPU Operator bundle image has been changed from GitLab registry to GitHub Container Registry, which properly implements the PR objective.
|
/test |
|
@empovit: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test 4.18-stable-nvidia-gpu-operator-e2e-master |
|
The rehearsal job was OK
@wabouhamad could you please fix the Renovate file as @TomerNewman has suggested, and we'll merge the PR? No need to re-test. Lines 12 to 15 in 74b4864 |
Updating GPU Operator OLM master bundle image path to new link: ghcr.io/nvidia/gpu-operator/gpu-operator-bundle:main-latest
wabouhamad
force-pushed
the
gpu-bundle-path-update-2025-02-28
branch
from
34c58a8 to
21ab644
Compare
Done. |
|
@TomerNewman @empovit PTAL, updated the renovate.json file. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
76-76: Update of GPU Operator bundle image default value and minor formatting tweaks.
The new default value forNVIDIAGPU_BUNDLE_IMAGEis correctly updated to
ghcr.io/nvidia/gpu-operator/gpu-operator-bundle:main-latest, which aligns with the new registry source.
Note: There is a small typo in the description text ("bundlle" should be "bundle"). Also, markdownlint suggests using asterisks (*) instead of dashes for unordered list items. Consider updating the bullet style if consistency is desired.Diff suggestion for typo fix:
- ghcr.io/nvidia/gpu-operator/gpu-operator-bundle:main-latest - _optional when deploying from bundlle_ + ghcr.io/nvidia/gpu-operator/gpu-operator-bundle:main-latest - _optional when deploying from bundle_🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
76-76: Unordered list style
Expected: asterisk; Actual: dash(MD004, ul-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
README.md(1 hunks)internal/deploy/deploy.go(1 hunks)internal/deploy/deploy_test.go(1 hunks)renovate.json(1 hunks)tests/nvidiagpu/deploy-gpu-test.go(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- internal/deploy/deploy.go
- tests/nvidiagpu/deploy-gpu-test.go
- internal/deploy/deploy_test.go
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
76-76: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
🔇 Additional comments (2)
renovate.json (2)
13-13: Correct update ofdepNameTemplate.
ThedepNameTemplateis now set to"ghcr.io/nvidia/gpu-operator/gpu-operator-bundle", replacing the previous GitLab-based value. This ensures that the Renovate configuration points to the new GitHub Container Registry.
15-15: Correct update ofregistryUrlTemplate.
TheregistryUrlTemplateis updated to"https://ghcr.io", consistent with the new bundle image source. This change matches the intended shift from GitLab to GitHub Container Registry.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: empovit, wabouhamad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2d37c74
into
rh-ecosystem-edge:main
Updating GPU Operator OLM master bundle image path to new link:
ghcr.io/nvidia/gpu-operator/gpu-operator-bundle:main-latest
Summary by CodeRabbit
Documentation
Chores