Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPU Operator staging digest to sha256:a2d5ce3049990e195fce8b945827cdefdb924353af4b1ab5e9cd57fab54cf75d #61

Conversation

red-hat-konflux[bot]
Copy link
Contributor

@red-hat-konflux red-hat-konflux bot commented Mar 2, 2025

This PR contains the following updates:

Package Update Change
registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator-bundle digest 3e44858 -> a2d5ce3

/test 4.12-stable-nvidia-gpu-operator-e2e-master 4.14-stable-nvidia-gpu-operator-e2e-master 4.15-stable-nvidia-gpu-operator-e2e-master 4.16-stable-nvidia-gpu-operator-e2e-master 4.17-stable-nvidia-gpu-operator-e2e-master 4.18-stable-nvidia-gpu-operator-e2e-master


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

…5827cdefdb924353af4b1ab5e9cd57fab54cf75d

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from empovit and fabiendupont March 2, 2025 13:43
Copy link

openshift-ci bot commented Mar 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign ggordanired for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

coderabbitai bot commented Mar 2, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

openshift-ci bot commented Mar 2, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Mar 2, 2025

@red-hat-konflux[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

This PR contains the following updates:

Package Update Change
registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator-bundle digest 3e44858 -> a2d5ce3

/test 4.12-stable-nvidia-gpu-operator-e2e-master 4.14-stable-nvidia-gpu-operator-e2e-master 4.15-stable-nvidia-gpu-operator-e2e-master 4.16-stable-nvidia-gpu-operator-e2e-master 4.17-stable-nvidia-gpu-operator-e2e-master 4.18-stable-nvidia-gpu-operator-e2e-master


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@empovit
Copy link
Member

empovit commented Mar 2, 2025

/hold

@TomerNewman I think we can skip this if we test the PRs that update OpenShift versions. Also, can we limit the main branch tests to one, maybe two OpenShift versions? It will change frequently, and isn't a production version, so I think a quick sanity check would suffice.

@empovit
Copy link
Member

empovit commented Mar 2, 2025

/uncc @fabiendupont
/cc @TomerNewman

@openshift-ci openshift-ci bot requested review from TomerNewman and removed request for fabiendupont March 2, 2025 14:52
@empovit
Copy link
Member

empovit commented Mar 2, 2025

@TomerNewman I mean we can skip this PR as the same combination of bundle + OpenShift version will be already tested by the other red-hat-konflux bot PRs.

My comment about OpenShift versions is related to the fact that the bundle will change often, and we only want to make sure it's not completely broken. So I think we need to test it only on - let's say - 4.18 and 4.12, instead of all versions:

/test 4.12-stable-nvidia-gpu-operator-e2e-master 4.14-stable-nvidia-gpu-operator-e2e-master 4.15-stable-nvidia-gpu-operator-e2e-master 4.16-stable-nvidia-gpu-operator-e2e-master 4.17-stable-nvidia-gpu-operator-e2e-master 4.18-stable-nvidia-gpu-operator-e2e-master

A release will have to pass through more comprehensive tests though, on all supported versions of OpenShift.

@empovit
Copy link
Member

empovit commented Mar 2, 2025

/hold

@empovit
Copy link
Member

empovit commented Mar 2, 2025

/unhold
/skip

@empovit empovit merged commit 6f26506 into main Mar 2, 2025
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant