ignore the pr - testing something #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. nfd consts put in nfd package and imported
2. used UndefinedValue const in gpu test instead of the string "undefined"
…ts package, and adjusted imports
… package, and adjusted imports
… also logging adjusted accordingly so once you change the time const the loging automatically is updated
2. fixed nfd consts names 3.fixed nfd var bug - create instance per package not global nfd
Bumps the go_modules group with 1 update: [github.com/golang/glog](https://github.com/golang/glog). Updates `github.com/golang/glog` from 1.2.0 to 1.2.4 - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.2.0...v1.2.4) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]>
This reverts commit b7aa1ea.
NFD vars seperated in gpu and nno NFD consts seperated in gpu and nno 1.nfd package created 2. nfd consts put in nfd package and imported 1.common consts added to nfd consts even tho theyre not nfd 2. used UndefinedValue const in gpu test instead of the string "undefined" put the consts of nfd package in its correct directory not in the tests package, and adjusted imports put the vars of nfd package in its correct directory not in the tests package, and adjusted imports gpu consts put in the gpu package and names adjusted to remove redundant info added some time consts in the consts file of the package of nvidiagpu also logging adjusted accordingly so once you change the time const the loging automatically is updated added a 2 consts to the nfd package and used them 1. seperated global variables from nfd vars 2. fixed nfd consts names 3.fixed nfd var bug - create instance per package not global nfd
…ite_list Add white list
… both nno and nvidiagpu via image are called CustomConfig
bash-3.2$ make run-tests
test -s gpu-operator-must-gather.sh || (\
SCRIPT_URL="https://raw.githubusercontent.com/NVIDIA/gpu-operator/v23.9.1/hack/must-gather.sh" && \
if ! curl -SsL -o gpu-operator-must-gather.sh -L $SCRIPT_URL; then \
echo "Failed to download must-gather script" >&2; \
exit 1; \
fi && \
chmod +x gpu-operator-must-gather.sh \
)
Executing nvidiagpu test-runner script
scripts/test-runner.sh
PATH_TO_MUST_GATHER_SCRIPT=/Users/walid/GitHub/RH-ECOSYSTEM-EDGE/nvidia-ci-Adam-PR55-NFD-refactoring-020525/nvidia-ci/gpu-operator-must-gather.sh ginkgo -timeout=24h --keep-going --require-suite -r --trace --label-filter="nno" ./tests/nvidianetwork
Failed to compile nvidianetwork:
# github.com/rh-ecosystem-edge/nvidia-ci/tests/nvidianetwork [github.com/rh-ecosystem-edge/nvidia-ci/tests/nvidianetwork.test]
./deploy-nno-test.go:35:8: not enough arguments in call to nfd.NewConfig
have ()
want (string)
./deploy-nno-test.go:187:9: Nfd.CustomCatalogSourceIndexImage undefined (type *nfd.Config has no field or method CustomCatalogSourceIndexImage)
./deploy-nno-test.go:192:9: Nfd.CreateCustomCatalogsource undefined (type *nfd.Config has no field or method CreateCustomCatalogsource)
./deploy-nno-test.go:194:9: Nfd.CustomCatalogSource undefined (type *nfd.Config has no field or method CustomCatalogSource)
./deploy-nno-test.go:196:10: Nfd.CustomCatalogSource undefined (type *nfd.Config has no field or method CustomCatalogSource)
./deploy-nno-test.go:201:9: Nfd.CreateCustomCatalogsource undefined (type *nfd.Config has no field or method CreateCustomCatalogsource)
./deploy-nno-test.go:229:9: Nfd.CleanupAfterInstall undefined (type *nfd.Config has no field or method CleanupAfterInstall)
./deploy-nno-test.go:239:13: Nfd.CreateCustomCatalogsource undefined (type *nfd.Config has no field or method CreateCustomCatalogsource)
./deploy-nno-test.go:241:24: Nfd.CustomCatalogSource undefined (type *nfd.Config has no field or method CustomCatalogSource)
./deploy-nno-test.go:243:46: Nfd.CustomCatalogSource undefined (type *nfd.Config has no field or method CustomCatalogSource)
./deploy-nno-test.go:243:46: too many errors
Ginkgo ran 1 suite in 1.46310275s
Test Suite Failed
make: *** [run-tests] Error 1
bash-3.2$
2.createNFDDeployment adjusted and moved to the deploy package these things both were common in the nno and gpu test thus adjusted accordingly deploy-gpu-test.go without scaling passed
…urn test * the gpu burn test passed on a single node cluster
* the gpu burn test passed on a single node cluster
…ncerns) pkg/nfd: Manages NFD resource creation and verification pkg/nfdcheck: Verifies that NFD is correctly installed and configured * the gpu burn test passed on a single node cluster
added comments Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…nternal from pkg added these funcs: EnsureNFDIsInstalled DeployNFDOperatorWithRetries 1.gpu-used the new funcs here 2.nno - havent added them here yet * the gpu burn test passed on a single node cluster DeleteOLMPods- needs to be put in a diffrent package its currently in nfd pkg
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AdamKaabyia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Caution Review failedThe pull request is closed. WalkthroughThe changes update dependency versions in Changes
Sequence Diagram(s)sequenceDiagram
participant Client as API Client
participant NFD as NFD Utils
participant Deploy as Deployment Manager
participant Catalog as CatalogSource
Client->>NFD: EnsureNFDIsInstalled()
alt NFD not installed
NFD->>Catalog: Check package manifest
Catalog-->>NFD: Manifest result
NFD->>Deploy: CreateNFDDeployment()
Deploy-->>NFD: Deployment status
NFD->>NFD: If needed, call DeleteOLMPods()
else NFD installed
NFD-->>Client: Return installed status
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @AdamKaabyia. Thanks for your PR. I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores
Refactor