[OPENJDK-3597] test for MAVEN_SETTINGS_XML #539
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sefroberg
approved these changes
Jan 24, 2025
jerboaa
reviewed
Jan 24, 2025
There was a problem hiding this comment.
I'd prefer if this waited for the test application merge in rh-openjdk/openjdk-container-test-applications#7 Using personal forks isn't something we should sprinkle around in our code-base.
jmtd
force-pushed
the
OPENJDK-3597-enforce-profile-active
branch
from
3836e66 to
720efd6
Compare
|
@jerboaa I've merged rh-openjdk/openjdk-container-test-applications#7 and updated this PR accordingly. Please take another look :-) (related: we have to specify |
This test checks a custom test application source to ensure that a custom settings.xml, which defines a custom profile, has been activated. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
jmtd
force-pushed
the
OPENJDK-3597-enforce-profile-active
branch
from
720efd6 to
38d9c00
Compare
jerboaa
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks a custom test application source to ensure that a custom settings.xml, which defines a custom profile, has been activated.
https://issues.redhat.com/browse/OPENJDK-3597
Note: once rh-openjdk/openjdk-container-test-applications#7 is merged, this could be rebased to reference
rh-openjdkinstead of thejmtdfork.Also note: the S2I tests are tagged
@ignorewhich prevents their execution on GHA; to run them manually, one has to remove or comment out@ignoreat the top of the file, and most likely add@wipto each of them, in order to select them wtihcekit … test behave --wip.