-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement centralised logging in ceph dashboard using Grafana Loki #48
base: main
Are you sure you want to change the base?
Conversation
Fixes: https://tracker.ceph.com/issues/50491 Signed-off-by: Aashish Sharma <[email protected]>
This is a WIP PR to implement centralized logging in a ceph-dev cluster. Future enhancements include implementing this on a kcli cluster. To test this PR out -
|
@@ -163,6 +163,24 @@ services: | |||
- ./docker/haproxy/cors.lua:/etc/haproxy/cors.lua | |||
scale: -1 | |||
|
|||
loki: | |||
image: grafana/loki:2.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the .env.example
the appropriate entry for this variable:
image: grafana/loki:2.4.0 | |
image: ${LOKI_IMAGE:-grafana/loki:2.4.0} |
command: '--config.file=/etc/loki/loki-config.yaml' | ||
|
||
promtail: | ||
image: grafana/promtail:2.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the .env.example the appropriate entry for this variable:
image: grafana/promtail:2.4.0 | |
image: ${PROMTAIL_IMAGE:-grafana/promtail:2.4.0} |
promtail: | ||
image: grafana/promtail:2.4.0 | ||
volumes: | ||
- /var/log:/var/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to share the host whole log folder or can we share a more specific folder?
- /var/log:/var/log | ||
- ./docker/promtail:/etc/promtail | ||
- ${CEPH_REPO_DIR}/build.ceph/out:/etc/logs | ||
command: '--config.file=/etc/promtail/promtail-config.yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if our version of docker-compose supports it, but what about using depends-on:
to make promtail run when loki is launched (or the other way around)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current version supports it:
https://docs.docker.com/compose/compose-file/compose-file-v2/#depends_on
Fixes: https://tracker.ceph.com/issues/50491
Signed-off-by: Aashish Sharma [email protected]