Ensure there's always an opened GDK display present #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jikortus
force-pushed
the
gdk-display-workaround
branch
from
a638960 to
030ce4f
Compare
Sometimes it happens that there's no GDK display present and this leads to a traceback when a keyCombo() is sent. It's not entirely sure if this is a bug in dogtail or if we should open the display explicitly ourselves. We can remove this piece of code in the future if we find out that this should rather get fixed in dogtail.
jikortus
force-pushed
the
gdk-display-workaround
branch
from
030ce4f to
f10a506
Compare
jstodola
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it happens that there's no GDK display present and this leads to a traceback when a keyCombo() is sent. It's not entirely sure if this is a bug in dogtail or if we should open the display explicitly ourselves. We can remove this piece of code in the future if we find out that this should rather get fixed in dogtail.
I have discussed this problem with Michal Odehnal and it's not clear if dogtail should explicitly take care of the display opening or not. We agreed on opening the display explicitly in Anabot at least for now, with further discussions/investigation in the new year.
I have tested this change locally in a VM on both RHEL-9 and 10 (I added
Gdk.Display.get_default().close()so that the code within the condition got executed).